[
https://issues.apache.org/jira/browse/GOBBLIN-1011?focusedWorklogId=362654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362654
]
ASF GitHub Bot logged work on GOBBLIN-1011:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 19:04
Start Date: 23/Dec/19 19:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2856:
[GOBBLIN-1011] adjust compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r360973178
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/suite/CompactionSuiteBase.java
##########
@@ -46,14 +50,17 @@
@Slf4j
public class CompactionSuiteBase implements CompactionSuite<FileSystemDataset>
{
public static final String SERIALIZE_COMPACTION_FILE_PATH_NAME =
"compaction-file-path-name";
- private State state;
- private CompactionJobConfigurator configurator = null;
+ protected State state;
+ protected CompactionJobConfigurator configurator;
+ private static final Gson GSON =
GsonInterfaceAdapter.getGson(FileSystemDataset.class);
+ private static final String SERIALIZED_DATASET =
"compaction.serializedDataset";
Review comment:
please remove old key name if you decide to replace it with a new name, also
why this change ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362654)
> Adjust compaction flow to work with virtual partition
> -----------------------------------------------------
>
> Key: GOBBLIN-1011
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1011
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> - Update existing `CompactionVerifier`s and `CompactionCompleteAction`s to
> work with virtual simple file system dataset proply
> - Improve ser/de of `FileSystemDataset` in `CompactionSuiteBase`
> - Update gobblin-hive-registration to work with table parameters properly
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
