[
https://issues.apache.org/jira/browse/GOBBLIN-1011?focusedWorklogId=362837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362837
]
ASF GitHub Bot logged work on GOBBLIN-1011:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Dec/19 01:32
Start Date: 24/Dec/19 01:32
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2856: [GOBBLIN-1011]
adjust compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r361040056
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/action/CompactionCompleteFileOperationAction.java
##########
@@ -73,6 +74,11 @@ public CompactionCompleteFileOperationAction (State state,
CompactionJobConfigur
* Create a record count file containing the number of records that have
been processed .
*/
public void onCompactionJobComplete (FileSystemDataset dataset) throws
IOException {
+ if (dataset instanceof SimpleFileSystemDataset
Review comment:
How about extending the FileSystemDataset interface with an isVirtual()
method that defaults to false to avoid this specific instanceof and casting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362837)
Time Spent: 3h (was: 2h 50m)
> Adjust compaction flow to work with virtual partition
> -----------------------------------------------------
>
> Key: GOBBLIN-1011
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1011
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> - Update existing `CompactionVerifier`s and `CompactionCompleteAction`s to
> work with virtual simple file system dataset proply
> - Improve ser/de of `FileSystemDataset` in `CompactionSuiteBase`
> - Update gobblin-hive-registration to work with table parameters properly
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
