[
https://issues.apache.org/jira/browse/GOBBLIN-1083?focusedWorklogId=415881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415881
]
ASF GitHub Bot logged work on GOBBLIN-1083:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/20 01:44
Start Date: 04/Apr/20 01:44
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2923: [GOBBLIN-1083]
Unit test improving & return failed when helix task cancelled
URL:
https://github.com/apache/incubator-gobblin/pull/2923#issuecomment-608952545
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=h1)
Report
> Merging
[#2923](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ef461ad37bb54c023bd383608a3c4024adad06f&el=desc)
will **decrease** coverage by `0.00%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2923 +/- ##
============================================
- Coverage 45.59% 45.59% -0.01%
+ Complexity 9160 9159 -1
============================================
Files 1936 1936
Lines 73295 73300 +5
Branches 8088 8088
============================================
Hits 33418 33418
- Misses 36781 36787 +6
+ Partials 3096 3095 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `77.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
|
[...e/gobblin/cluster/TaskRunnerSuiteProcessModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlUHJvY2Vzc01vZGVsLmphdmE=)
| `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
|
[...he/gobblin/writer/FineGrainedWatermarkTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL0ZpbmVHcmFpbmVkV2F0ZXJtYXJrVHJhY2tlci5qYXZh)
| `82.25% <ø> (ø)` | `28.00 <0.00> (ø)` | |
|
[...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh)
| `67.26% <ø> (ø)` | `84.00 <0.00> (ø)` | |
|
[.../apache/gobblin/runtime/task/BaseAbstractTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGFzay9CYXNlQWJzdHJhY3RUYXNrLmphdmE=)
| `52.38% <0.00%> (-8.74%)` | `6.00 <0.00> (ø)` | |
|
[...va/org/apache/gobblin/runtime/task/FailedTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGFzay9GYWlsZWRUYXNrLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `37.30% <50.00%> (-3.18%)` | `15.00 <0.00> (-1.00)` | |
|
[.../java/org/apache/gobblin/cluster/SleepingTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2xlZXBpbmdUYXNrLmphdmE=)
| `48.48% <80.00%> (+9.09%)` | `3.00 <0.00> (ø)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0.00%> (-1.57%)` | `15.00% <0.00%> (-1.00%)` | |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2923/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=footer).
Last update
[9ef461a...cc02f49](https://codecov.io/gh/apache/incubator-gobblin/pull/2923?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415881)
Time Spent: 1h 10m (was: 1h)
> Maximize helix retry by returning failure when cancel
> -----------------------------------------------------
>
> Key: GOBBLIN-1083
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1083
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
