[
https://issues.apache.org/jira/browse/GOBBLIN-1083?focusedWorklogId=417538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417538
]
ASF GitHub Bot logged work on GOBBLIN-1083:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/20 08:19
Start Date: 07/Apr/20 08:19
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2923:
[GOBBLIN-1083] Unit test improving & return failed when helix task cancelled
URL: https://github.com/apache/incubator-gobblin/pull/2923#discussion_r404623597
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/task/FailedTask.java
##########
@@ -16,19 +16,30 @@
*/
package org.apache.gobblin.runtime.task;
+import org.apache.gobblin.configuration.ConfigurationKeys;
import org.apache.gobblin.configuration.WorkUnitState;
import org.apache.gobblin.publisher.DataPublisher;
import org.apache.gobblin.publisher.NoopPublisher;
import org.apache.gobblin.runtime.JobState;
import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.runtime.TaskState;
import org.apache.gobblin.source.workunit.WorkUnit;
+import com.google.common.base.Throwables;
+
+import groovy.util.logging.Slf4j;
+
+
/**
- * A task which raise an exception when run
+ * A task which returns "FAILED" state directly.
*/
+@Slf4j
public class FailedTask extends BaseAbstractTask {
- public FailedTask (TaskContext taskContext) {
+ private final TaskContext taskContext;
Review comment:
Oh yes, maybe have this in BaseAbstractTask so it can be removed from all
child classes like I said in previous comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 417538)
Time Spent: 2h 40m (was: 2.5h)
> Maximize helix retry by returning failure when cancel
> -----------------------------------------------------
>
> Key: GOBBLIN-1083
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1083
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
