sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r453027666
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##########
@@ -104,7 +104,9 @@ public GobblinApplicationMaster(String applicationName,
String applicationId, Co
if (UserGroupInformation.isSecurityEnabled()) {
LOGGER.info("Adding YarnContainerSecurityManager since security is
enabled");
-
this.applicationLauncher.addService(buildYarnContainerSecurityManager(this.config,
this.fs));
+ YarnContainerSecurityManager yarnContainerSecurityManager =
buildYarnContainerSecurityManager(this.config, this.fs);
Review comment:
One more comment: For safety, it may make sense to do the same action on
the worker nodes as well i.e. on start up read the latest tokens from the token
file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
