sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r454569680
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##########
@@ -229,6 +227,8 @@ public static void main(String[] args) throws Exception {
printUsage(options);
System.exit(1);
}
+ Config config = ConfigFactory.load();
Review comment:
Also it would be good to add a comment explaining why the token update
is done in the main() i.e "Because AM is restarted with the original
AppSubmissionContext, it may have outdated delegation tokens. So the refreshed
tokens should be added into the container's UGI before any HDFS/Hive/RM access
is performed."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
