[ 
https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937738#comment-13937738
 ] 

Renato Javier MarroquĂ­n Mogrovejo edited comment on GORA-246 at 3/17/14 12:25 
PM:
----------------------------------------------------------------------------------

Hi [~alparslan.avci],

So for 1, I am looking into revision 1574715 and the part of the map entry 
removal test looks as follow:

 // map entry removal test
    for (int i = 0; i < urls.length; i++) {
      WebPage webPage = dataStore.get(urls[i]);
      for (int j = 1; j < urls.length; j += 2) {
        webPage.getOutlinks().put(new Utf8(anchor + j), null);
      }
      dataStore.put(webPage.getUrl().toString(), webPage);
    }
    dataStore.flush();
Which also looks wrong as well. It seems like it is in the first for it is 
putting all outlinks, and in the second is just adding the odd ones (even 
though none was taken out). I will modify this test to actually test what we 
are trying to, and then fix the other data stores accordingly, wdyt?


was (Author: renato2099):
Hi [~alparslan.avci],

So for 1, I am looking into revision 1574715 and the part of the map entry 
removal test looks as follow:

{code // map entry removal test
    for (int i = 0; i < urls.length; i++) {
      WebPage webPage = dataStore.get(urls[i]);
      for (int j = 1; j < urls.length; j += 2) {
        webPage.getOutlinks().put(new Utf8(anchor + j), null);
      }
      dataStore.put(webPage.getUrl().toString(), webPage);
    }
    dataStore.flush();}
Which also looks wrong as well. It seems like it is in the first for it is 
putting all outlinks, and in the second is just adding the odd ones (even 
though none was taken out). I will modify this test to actually test what we 
are trying to, and then fix the other data stores accordingly, wdyt?

> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
>                 Key: GORA-246
>                 URL: https://issues.apache.org/jira/browse/GORA-246
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: gora-core, gora-hbase
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 0.4
>
>         Attachments: GORA-246.FailingTest.patch, GORA-246.patch, 
> GORA-246v2.patch, GORA-246v3.patch, GORA-246v3.patch, GORA-246v4.patch, 
> GORA-246v5.patch, GORA_246.HBaseDriverTest.patch, 
> GORA_246.HBaseDriverTest.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to