[ 
https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937835#comment-13937835
 ] 

Renato Javier MarroquĂ­n Mogrovejo edited comment on GORA-246 at 3/17/14 2:00 PM:
---------------------------------------------------------------------------------

Hi [~alparslan.avci],

Thank you for pointing that out. AFAIK GORA-207 didn't target nested structures 
as we are dealing with right now. This is indeed a much more difficult task. It 
only deals with unions at the first level. Maybe we should open a new JIRA to 
tackle this in the future.
This is also the reason why we'd need to make the question about the 
{{qualifier == null}} on the maps, because as this is a nested structure we 
"don't know" if we are dealing with a family (nested structure) or a column 
(just a regular map).
So what do you think if we change the test what is shown below, and create a 
new JIRA for handling and testing nested structure updates.
{{
    // map entry removal test
    for (int i = 0; i < urls.length; i++) {
      WebPage webPage = dataStore.get(urls[i]);
      for (int j = 1; j < urls.length; j += 2) {
        webPage.getOutlinks().remove(new Utf8(anchor + j));
      }
      dataStore.put(webPage.getUrl().toString(), webPage);
    }
}}


was (Author: renato2099):
Hi [~alparslan.avci],

Thank you for pointing that out. AFAIK GORA-207 didn't target nested structures 
as we are dealing with right now. This is indeed a much more difficult task. It 
only deals with unions at the first level. Maybe we should open a new JIRA to 
tackle this in the future.
This is also the reason why we'd need to make the question about the 
{{qualifier == null}} on the maps, because as this is a nested structure we 
"don't know" if we are dealing with a family (nested structure) or a column 
(just a regular map).
So what do you think if we change the test what is shown below, and create a 
new JIRA for handling and testing nested structure updates.
{code
    // map entry removal test
    for (int i = 0; i < urls.length; i++) {
      WebPage webPage = dataStore.get(urls[i]);
      for (int j = 1; j < urls.length; j += 2) {
        webPage.getOutlinks().remove(new Utf8(anchor + j));
      }
      dataStore.put(webPage.getUrl().toString(), webPage);
    }
}

> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
>                 Key: GORA-246
>                 URL: https://issues.apache.org/jira/browse/GORA-246
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: gora-core, gora-hbase
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 0.4
>
>         Attachments: GORA-246.FailingTest.patch, GORA-246.patch, 
> GORA-246v2.patch, GORA-246v3.patch, GORA-246v3.patch, GORA-246v4.patch, 
> GORA-246v5.patch, GORA_246.HBaseDriverTest.patch, 
> GORA_246.HBaseDriverTest.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to