[ 
https://issues.apache.org/jira/browse/GORA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125082#comment-14125082
 ] 

ASF GitHub Bot commented on GORA-346:
-------------------------------------

GitHub user lewismc opened a pull request:

    https://github.com/apache/gora/pull/6

    GORA-346 Create shim layer to support multiple hadoop versions

    Hi Folks,
    OK so this PR rebases this patch against master branch.
    The only issues I have are as following
    
     * ALL new modules within the Hadoop Shims patch are packaged as bundle... 
is this OK?
     * I do not understand the comment by Henry regarding  "2. Make hadoop shim 
instance to be final in the Hadoop util." If we can clarify this then I can add 
to the PR and we can commit.
    Thank you
    Lewis

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lewismc/gora GORA-346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit b51cdeeadc1e79474acd250e51a77645ad676ce6
Author: Lewis John McGibbney <lewis.j.mcgibb...@jpl.nasa.gov>
Date:   2014-09-07T22:49:09Z

    GORA-346 Create shim layer to support multiple hadoop versions

----


> Create shim layer to support multiple hadoop versions
> -----------------------------------------------------
>
>                 Key: GORA-346
>                 URL: https://issues.apache.org/jira/browse/GORA-346
>             Project: Apache Gora
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Renato Javier MarroquĂ­n Mogrovejo
>            Assignee: Moritz Hoffmann
>              Labels: patch
>             Fix For: 0.5
>
>         Attachments: GORA-345_MUNGE_v1.patch, GORA-346_v1.patch, 
> GORA-346_v2.patch, GORA-346_v3.patch, GORA-346_v4_profiles.patch, 
> GORA-346_v5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to