[
https://issues.apache.org/jira/browse/GORA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125248#comment-14125248
]
ASF GitHub Bot commented on GORA-346:
-------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/gora/pull/6#discussion_r17223459
--- Diff:
gora-core/src/main/java/org/apache/gora/mapreduce/GoraMapReduceUtils.java ---
@@ -36,6 +38,8 @@
*/
public class GoraMapReduceUtils {
+ private static HadoopShim hadoopShim =
HadoopShimFactory.INSTANCE().getHadoopShim();
--- End diff --
Let's make this final to support immutability pattern.
> Create shim layer to support multiple hadoop versions
> -----------------------------------------------------
>
> Key: GORA-346
> URL: https://issues.apache.org/jira/browse/GORA-346
> Project: Apache Gora
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Renato Javier Marroquín Mogrovejo
> Assignee: Moritz Hoffmann
> Labels: patch
> Fix For: 0.5
>
> Attachments: GORA-345_MUNGE_v1.patch, GORA-346_v1.patch,
> GORA-346_v2.patch, GORA-346_v3.patch, GORA-346_v4_profiles.patch,
> GORA-346_v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
