[ 
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606348#comment-17606348
 ] 

ASF GitHub Bot commented on GORA-698:
-------------------------------------

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r973769144


##########
gora-geode/src/test/java/store/TestGeodeStore.java:
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package store;
+
+
+
+import org.apache.avro.util.Utf8;
+import org.apache.gora.examples.WebPageDataCreator;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.geode.GeodeStartupLogWaitStrategy;
+import org.apache.gora.geode.GoraGeodeTestDriver;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.query.Query;
+import org.apache.gora.store.DataStoreTestBase;
+import org.apache.gora.util.GoraException;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+
+
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
+import java.time.Duration;
+
+import static org.junit.Assert.*;
+
+/**
+ * Tests extending {@link DataStoreTestBase}
+ * which run the base JUnit test suite for Gora.
+ */
+public class TestGeodeStore extends DataStoreTestBase {

Review Comment:
   Could you add more tests?





> Add GEODE Support
> -----------------
>
>                 Key: GORA-698
>                 URL: https://issues.apache.org/jira/browse/GORA-698
>             Project: Apache Gora
>          Issue Type: New Feature
>            Reporter: Himanshu
>            Priority: Major
>
>  [1]https://geode.apache.org/



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to