[
https://issues.apache.org/jira/browse/GOSSIP-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130871#comment-16130871
]
ASF GitHub Bot commented on GOSSIP-38:
--------------------------------------
Github user edwardcapriolo commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/66#discussion_r133777741
--- Diff:
gossip-base/src/main/java/org/apache/gossip/event/GossipListener.java ---
@@ -21,4 +21,7 @@
public interface GossipListener {
void gossipEvent(Member member, GossipState state);
+
+ /* this listener's name */
+ String name();
--- End diff --
The user creating the Listener can decided to use a class with a property
like name if they wish, but having two methods here removes the ability to use
lambda's which I believe makes them less "fun"
> Multiple async GossipListeners
> ------------------------------
>
> Key: GOSSIP-38
> URL: https://issues.apache.org/jira/browse/GOSSIP-38
> Project: Gossip
> Issue Type: New Feature
> Reporter: Edward Capriolo
> Assignee: Pooya Salehi
> Fix For: 0.1.3
>
>
> Currently Gossip allows us to specific 0-1 synchronous event listeners.
> In Hama:
> https://github.com/apache/hama/blob/master/core/src/main/java/org/apache/hama/monitor/fd/NodeEventListener.java
> They can attach multiple async listeners. I like this design better unsure if
> we should support both or only the async kind.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
