[
https://issues.apache.org/jira/browse/GOSSIP-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133136#comment-16133136
]
ASF GitHub Bot commented on GOSSIP-38:
--------------------------------------
Github user edwardcapriolo commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/66#discussion_r133989277
--- Diff:
gossip-base/src/main/java/org/apache/gossip/manager/GossipMemberStateRefresher.java
---
@@ -112,10 +115,16 @@ public boolean
processOptimisticShutdown(Entry<LocalMember, GossipState> l) {
if (s.getShutdownAtNanos() > l.getKey().getHeartbeat()) {
members.put(l.getKey(), GossipState.DOWN);
if (l.getValue() == GossipState.UP) {
- listener.gossipEvent(l.getKey(), GossipState.DOWN);
+ for (GossipListener listener: listeners)
--- End diff --
We have a number of executors around the code. You should follow the
pattern used elsewhere to setup the pool, add metrics, deal with rejecting, etc
> Multiple async GossipListeners
> ------------------------------
>
> Key: GOSSIP-38
> URL: https://issues.apache.org/jira/browse/GOSSIP-38
> Project: Gossip
> Issue Type: New Feature
> Reporter: Edward Capriolo
> Assignee: Pooya Salehi
> Fix For: 0.1.3
>
>
> Currently Gossip allows us to specific 0-1 synchronous event listeners.
> In Hama:
> https://github.com/apache/hama/blob/master/core/src/main/java/org/apache/hama/monitor/fd/NodeEventListener.java
> They can attach multiple async listeners. I like this design better unsure if
> we should support both or only the async kind.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
