Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/299#discussion_r194870376
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
 ---
    @@ -189,7 +197,7 @@ private LDAPConnection bindAs(Credentials credentials)
     
         /**
          * Returns an AuthenticatedUser representing the user authenticated by 
the
    -     * given credentials.
    +     * given credentials. Also adds custom LDAP attributes to credentials 
object.
    --- End diff --
    
    Might want to update this comment to reflect the change from storing in 
`Credentials` to `AuthenticatedUser`


---

Reply via email to