Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/299#discussion_r195712691
  
    --- Diff: 
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/RemoteAuthenticatedUser.java
 ---
    @@ -67,6 +69,21 @@
          */
         private static final Pattern X_FORWARDED_FOR = Pattern.compile("^" + 
IP_ADDRESS_REGEX + "(, " + IP_ADDRESS_REGEX + ")*$");
     
    +    /**
    +     * Arbitrary attributes associated with this RemoteAuthenticatedUser 
object.
    +     */
    +    private Map<String, String> attributes = new HashMap<String, String>();
    --- End diff --
    
    I'm not sure if it's better to put this here, in this abstract class, or if 
this (along with the `@Override`s below) should only be done on the 
implementing classes, like `ModeledAuthenticatedUser`?  @mike-jumper any 
guidance?


---

Reply via email to