Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/299#discussion_r195792533
  
    --- Diff: 
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledAuthenticatedUser.java
 ---
    @@ -79,6 +84,7 @@ public ModeledAuthenticatedUser(AuthenticatedUser 
authenticatedUser,
             super(authenticatedUser.getAuthenticationProvider(), 
authenticatedUser.getCredentials());
             this.modelAuthenticationProvider = modelAuthenticationProvider;
             this.user = user;
    +        this.setAttributes(authenticatedUser.getAttributes());
    --- End diff --
    
    I think this properly should be:
    
        super.setAttributes(authenticatedUser.getAttributes());
    
    since `setAttributes()` is defined in `RemoteAuthenticatedUser`.


---

Reply via email to