Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/154#discussion_r199616415
  
    --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
    @@ -128,6 +114,12 @@ static void 
guac_rdpdr_device_fs_iorequest_handler(guac_rdpdr_device* device,
     }
     
     static void guac_rdpdr_device_fs_free_handler(guac_rdpdr_device* device) {
    +
    +    free(device->rdpdr);
    +    free((char *) device->device_name);
    +    free(device->dos_name);
    +    Stream_Free(device->device_announce, 1);
    --- End diff --
    
    Similar to `Stream_Copy()`, a compatibility macro will need to be added to 
allow this to build with FreeRDP 1.0, which defines `stream_free()` instead of 
`Stream_Free()`. Beware that `stream_free()` only accepts one parameter, always 
freeing the underlying buffer.


---

Reply via email to