Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199625343 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -200,10 +182,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin* rdpdr) { /* Init device */ device->rdpdr = rdpdr; device->device_id = id; - device->device_name = "Guacamole Printer"; + device->device_name = printer_name; + device->device_name_len = guac_utf8_strlen(device->device_name); + device->device_type = RDPDR_DTYP_PRINT; + device->dos_name = "PRN1\0\0\0\0"; + + /* Set up device announce stream */ + int prt_name_len = (device->device_name_len + 1) * 2; + device->device_announce_len = 44 + prt_name_len + + GUAC_PRINTER_DRIVER_LENGTH; + char prt_name[prt_name_len]; --- End diff -- Okay, will give it a shot.
---