nfantone commented on issue #455: GUACAMOLE-361: CAS global logout URL: https://github.com/apache/guacamole-client/pull/455#issuecomment-565571019 @mike-jumper many thanks for your replies. > Custom fields are serialized to JSON using Jackson. Anything accessible via a getter on the Field subclass )and not annotated to be ignored) will be present in the REST response from the authentication service that lists the expected fields. So am I right in understanding that adding an extra `String getLogoutURI()` method would expose its configured value as a `$scope.field` in CAS Angular controllers? Is there some further wiring-up that needs to happen in order to do that? > On the client side, logout is signaled using the guacLogout event. You might need to handle this on `$rootScope` Right. The issue we see is that `guacLogout` happens _before_ deleting the token. And since CAS logout takes the user _away_ from the application, it's crucial that we wait for the Guacamole invalidation to complete. > The reload you describe is a critical aspect of the client side of the authentication process. It isn't exactly a reload so much as it is a means of forcing AngularJS to reprocess the route. I'm sure it is and thought so as much. Correct me if I'm getting this wrong (probably am) - but the way it was designed, makes acting on events happening _after_ logout really tricky (or flat impossible) as the reload might interrupt the listening event callback execution. Also, in the case of CAS the reloading _does not take the user back lo the login screen_. So, to me, it looks as though this isn't quite working as intended for this scenario. > If the CAS session is still valid, then a new Guacamole session should then be created once the server side has validated the CAS token. This is not what we are seeing. But, regardless, if a user has logged out we should stop Guacamole from generating a new session.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
