nfantone commented on issue #455: GUACAMOLE-361: CAS global logout URL: https://github.com/apache/guacamole-client/pull/455#issuecomment-565574441 > I'm no longer sure if #346 or even the `guacLogout` event are the way to go for this I can't help but agree. From what I gathered, `guacLogout` in its current shape is useless for the purpose of this PR. > Hooking into those events and redirecting the user would potentially preempt tasks which are chained onto that logout promise, but which naturally would happen after guacLogout fires. Exactly. Or the other way around. It creates a race condition. > Perhaps there is a way to know that the user has just logged out within the handling of that CAS token field I'm not really familiar with the architecture here - but couldn't we "hijack" the logout logic by exposing a custom action/function from the auth extension and ensure it is called _after_ deleting the token, if defined? How do extensions typically extend core functionality? Is it always via events?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
