DouglasHeriot commented on issue #488: GUACAMOLE-919: Implement PostgreSQL defaultStatementTimeout and socketTimeout URL: https://github.com/apache/guacamole-client/pull/488#issuecomment-607567859 These properties are passed in as string properties. `"null"` means not-set for `defaultStatementTimeout` however `0` is not-set for `socketTimeout`. I initially decided to try and just keep the properties as strings, but `int` did make more sense for `socketTimeout`. https://mybatis.org/mybatis-3/configuration.html https://jdbc.postgresql.org/documentation/head/connect.html I agree int is nicer, so to keep consistency I have now made `defaultStatementTimeout` and `int` as well, and simply don't set the property on the backend if it's `0` to match the behaviour of `socketTimeout`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
