necouchman commented on a change in pull request #488: GUACAMOLE-919: Implement
PostgreSQL defaultStatementTimeout and socketTimeout
URL: https://github.com/apache/guacamole-client/pull/488#discussion_r402704371
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/PostgreSQLEnvironment.java
##########
@@ -47,6 +47,21 @@
*/
private static final int DEFAULT_PORT = 5432;
+ /**
+ * The default defaultStatementTimeout (in seconds),
+ * if POSTGRESQL_DEFAULT_STATEMENT_TIMEOUT is not specified.
+ * Default to null (no timeout)
+ * https://mybatis.org/mybatis-3/configuration.html
+ */
+ private static final String DEFAULT_DEFAULT_STATEMENT_TIMEOUT = "null";
Review comment:
I dug into this a little more, and it does not look to me like the string
value "null" is what they intend - I think just mean `NULL` in the since of not
setting anything. So, this should not be `"null"`, it should be `NULL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services