necouchman commented on PR #1079: URL: https://github.com/apache/guacamole-client/pull/1079#issuecomment-2819098933
@Turab : I haven't reviewed the actual changes, yet, but, just looking at the pull request, the commit messages need some work: * Each commit message needs the `GUACAMOLE-2055: ` tag prepended to it. * The commit messages need to be descriptive of the actual changes, beyond just things like `Fix typo`, etc. If you have trouble generating a commit message that's not an exact description of the changes made (`Fix typo on line 31 in file tr.json`), then consider squashing commits together. For some examples and hints, we recommend the following page: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
