necouchman commented on code in PR #1079:
URL: https://github.com/apache/guacamole-client/pull/1079#discussion_r2052762100
##########
extensions/guacamole-auth-duo/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,14 @@
+{
+
+ "DATA_SOURCE_DUO" : {
+ "NAME" : "Duo TFA Altyapısı"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_DUO_SIGNED_RESPONSE" : "",
+ "INFO_DUO_VALIDATION_CODE_INCORRECT" : "Duo doğrulama kodu yanlış.",
+ "INFO_DUO_AUTH_REQUIRED" : "Devam etmek için lütfen Duo
ile kimlik doğrulayın.",
+ "INFO_DUO_REDIRECT_PENDING" : "Lütfen bekleyin, Duo'ya
yönlendiriliyor..."
Review Comment:
These should generally be in alphabetical order:
```
INFO_DUO_AUTH_REQUIRED
INFO_DUO_REDIRECT_PENDING
INFO_DUO_VALIDATION_CODE_INCORRECT
```
##########
extensions/guacamole-auth-json/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,7 @@
+{
+
+ "DATA_SOURCE_JSON" : {
+ "NAME" : "JSON"
Review Comment:
If this string is not being translated, you don't need to provide this -
Guacamole will fall back to the English translation. If "JSON" is the Turkish
translation of the English "JSON", then please leave it.
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,32 @@
+{
+
+ "DATA_SOURCE_CAS" : {
+ "NAME" : "CAS SSO Altyapısı"
+ },
+
+ "DATA_SOURCE_OPENID" : {
+ "NAME" : "OpenID SSO Altyapısı"
+ },
+
+ "DATA_SOURCE_SAML" : {
+ "NAME" : "SAML SSO Altyapısı"
+ },
+
+ "DATA_SOURCE_SSL" : {
+ "NAME" : "SSL/TLS SSO Altyapısı"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_ID_TOKEN" : "",
+ "FIELD_HEADER_STATE" : "",
+ "FIELD_HEADER_TICKET" : "",
Review Comment:
No need to provide these.
##########
extensions/guacamole-auth-quickconnect/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,18 @@
+{
+
+ "DATA_SOURCE_QUICKCONNECT" : {
+ "NAME" : "QuickConnect"
Review Comment:
Similar to above - not sure if this is a Turkish translation or not?
##########
guacamole/src/main/frontend/src/translations/tr.json:
##########
@@ -0,0 +1,1241 @@
+{
+
+ "NAME" : "Türkçe",
+
+ "APP" : {
+
+ "NAME" : "Apache Guacamole",
+ "VERSION" : "${project.version}",
Review Comment:
These should *not* be included and should always be left to the default.
##########
extensions/guacamole-auth-totp/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,52 @@
+{
+
+ "DATA_SOURCE_TOTP" : {
+ "NAME" : "TOTP TFA Altyapısı"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_TOTP" : ""
Review Comment:
This is not necessary to include.
##########
extensions/guacamole-auth-ldap/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,7 @@
+{
+
+ "DATA_SOURCE_LDAP" : {
+ "NAME" : "LDAP"
Review Comment:
As above - if "LDAP" is the Turkish translation for "LDAP", you can leave
this, but if you're just not translating it, no need to provide this.
##########
extensions/guacamole-auth-radius/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,12 @@
+{
+
+ "DATA_SOURCE_RADIUS" : {
+ "NAME" : "RADIUS Altyapısı"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_RADIUS_STATE" : "",
+ "FIELD_HEADER_RADIUSCHALLENGE" : ""
+ }
Review Comment:
You don't need to include these, as the translation system will fall back to
the default (English) to fill these in.
##########
extensions/guacamole-auth-restrict/src/main/resources/translations/tr.json:
##########
@@ -0,0 +1,73 @@
+{
+
+ "DATA_SOURCE_LOGIN_RESTRICTIONS" : {
+ "NAME" : "Additional Restrictions"
Review Comment:
This looks untranslated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
