necouchman opened a new pull request, #611: URL: https://github.com/apache/guacamole-server/pull/611
This is likely the first of a couple of changes to correct issues with RAIL support in FreeRDP3 and in Guacamole's support of GFX. I finally stumbled upon the reason that the FreeRDP3 changes had broken RAIL support - the RAIL plugin was being loaded _only_ the `PreConnect` callback (`rdp_freerdp_pre_connect()`), and not in the `LoadChannels` callback (`rdp_freerdp_load_channels()`). The change in FreeRDP (https://github.com/FreeRDP/FreeRDP/commit/ef8c9e48e8acf61e16cb9fd547799067c87b20da) that broke this unified the reloading of channels into a single function that disconnected and closed all of the channels and then used the `LoadChannels` callback to reload all of them. Since RAIL was not being processed through that callback, it would get dropped but never reconnected. This moves the processing of the RAIL plugin, along with any user-defined static plugins, to the `LoadChannels` callback, which keeps it connected in recent FreeRDP 3.x versions. I think these changes are solid and ready to be merged - it's pretty simple, and seems to fix at least the RAIL plugin connection issue. That said, I'm still seeing some issues with RAIL when GFX support is enabled (hangs/disconnects/freezes) that don't occur when you disable GFX support, so I think there may be additional items to address related to the intersection of GFX + RAIL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
