mike-jumper commented on code in PR #611:
URL: https://github.com/apache/guacamole-server/pull/611#discussion_r2324348171
##########
src/protocols/rdp/channels/rail.c:
##########
@@ -64,24 +64,6 @@ static UINT
guac_rdp_rail_complete_handshake(RailClientContext* rail) {
guac_client* client = (guac_client*) rail->custom;
guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
- RAIL_HANDSHAKE_ORDER handshake = {
-
- /* Build number 7600 (0x1DB0) apparently represents Windows 7 and
- * compatibility with RDP 7.0. As of this writing, this is the same
- * build number sent for RAIL connections by xfreerdp. */
- .buildNumber = 7600
-
- };
-
- /* Send client handshake response */
- guac_client_log(client, GUAC_LOG_TRACE, "Sending RAIL handshake.");
- pthread_mutex_lock(&(rdp_client->message_lock));
- status = rail->ClientHandshake(rail, &handshake);
Review Comment:
Is this handled automatically by FreeRDP?
##########
src/protocols/rdp/settings.c:
##########
@@ -1683,7 +1683,8 @@ void guac_rdp_push_settings(guac_client* client,
if (guac_settings->remote_app != NULL) {
freerdp_settings_set_bool(rdp_settings, FreeRDP_Workarea, TRUE);
freerdp_settings_set_bool(rdp_settings, FreeRDP_RemoteApplicationMode,
TRUE);
- freerdp_settings_set_bool(rdp_settings,
FreeRDP_RemoteAppLanguageBarSupported, TRUE);
+ freerdp_settings_set_bool(rdp_settings,
FreeRDP_RemoteAppLanguageBarSupported, FALSE);
Review Comment:
Why is this changing to `FALSE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
