necouchman commented on PR #613: URL: https://github.com/apache/guacamole-server/pull/613#issuecomment-3216840078
> > This behavior was introduced in [c56412f](https://github.com/apache/guacamole-server/commit/c56412f69ebb07cdaed5c19d74178a315b709fd5) (GUAC-734: Return to echo after HTS. Return to echo on unexpected characters within OSC., 2014-06-11) for unknown reasons -- I don't know how to find that ticket (it's not GUACAMOLE-734). That ticket - GUAC-734 - comes from the old Glyptodon Jira issue tracker, before the project was part Apache community, so you won't find the ticket in the current Jira tracker. The change looks simple enough to me; however, I wonder what the implications of it may be in other situations. Right now it just echoes the character(s) out to the terminal. I'm not sure transparently ignoring them is 100% the right way to go. I'm thinking that: * At the very least, the unknown characters should still be logged at at the `DEBUG` level (or perhaps the `WARN` level, if we're changing it to not even print the characters?). * Maybe there should be a new configuration parameter for the protocols that use the terminal that allows toggling whether or not the characters are ignored? Perhaps a checkbox that says "Do not ignore unknown characters", where the default (unchecked) behavior is what you're proposing, here, that the characters are ignored, but one could tick the box and have it print those characters to the screen? @mike-jumper, thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
