krobelus commented on PR #613: URL: https://github.com/apache/guacamole-server/pull/613#issuecomment-3217004669
> That ticket - GUAC-734 - comes from the old Glyptodon Jira issue tracker I wonder if we can find it; just in case there was a particular reason this was introduced -- though I don't expect there is, probably it was an insignificant change due to a misunderstanding. > I'm thinking that: > * At the very least, the unknown characters should still be logged at at the `DEBUG` level (or perhaps the `WARN` level, if we're changing it to not even print the characters?). Yeah it makes a lot of sense to log OSC sequences, including unknown ones. But probably not one log statement per character, since the sequence only makes sense as a whole (and it can be hundreds of characters long). So I'd log it only after receiving the sequence terminator. > a new configuration parameter for the protocols that use the terminal that allows toggling whether or not the characters are ignored I don't expect that it will be a good idea to a add this config option, because turning it on will randomly break applications, and it's not even really useful for debugging, because the prefix of the sequence *is* consumed. So if you run a program that sneakily prints some escape sequence that's not supported by the terminal; printing a suffix is 1. noisy (because in these, users don't actually care that the escape sequence is not supported) 2. not even enough to identify the sequence, because the prefix is missing, so it could be OSC, DCS, APC etc. I don't think any terminal has this type of option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
