bbennett-ks commented on PR #627: URL: https://github.com/apache/guacamole-server/pull/627#issuecomment-3648424634
> > Overall I'm okay with it. Just a few comments. > > The only other concern I have is if there's any potential impact to ABI or API compatibility since this changes the type of several of those settings members from `int` to `unsigned short`? We generally try not to break compatibility in minor version releases like this, so I just want to make sure that doesn't bite us (or, more importantly, our users). > > It should be OK based on how it is used, but I'll revert those changes as they are unnecessary and adds risk. On second thought, the core fix that changes an out of range port value (doesn't fit inside an unsigned long) to the default value changes the ABI/API compatibility. So, changing the underlying data type doesn't introduce any additional functional impact. So if it's OK, I'll leave the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
