necouchman commented on code in PR #627:
URL: https://github.com/apache/guacamole-server/pull/627#discussion_r2615974322
##########
src/protocols/rdp/settings.c:
##########
@@ -1109,8 +1110,8 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
/* Port for SFTP connection */
settings->sftp_port =
- guac_user_parse_args_string(user, GUAC_RDP_CLIENT_ARGS, argv,
- IDX_SFTP_PORT, "22");
+ guac_user_parse_args_int_string_bound(user, GUAC_RDP_CLIENT_ARGS, argv,
+ IDX_SFTP_PORT, "22", 0, USHRT_MAX);
Review Comment:
I was actually thinking it might need to go to 1, but I did a quick search
and it looks like 0 is a valid TCP port number?? So it probably was okay the
way you originally had it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
