[ 
https://issues.apache.org/jira/browse/HAMA-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293248#comment-13293248
 ] 

Edward J. Yoon commented on HAMA-524:
-------------------------------------

It's so nice to see your progress and your process! 

Here's my minor comment:

{code}
    /**
     * Prints useful info about generated matrix: rows, columns, sparsity, items
     * count.
     */
    @Override
    public void cleanup(
        BSPPeer<NullWritable, NullWritable, Text, DoubleWritable, 
IntegerMessage> peer)
        throws IOException {
      if (peer.getPeerName().equals(masterTask)) {
        peer.write(new Text("Generated matix is"), null);
        peer.write(new Text("Sparsity    = "), new DoubleWritable(sparsity));
        peer.write(new Text("rows        = "), new DoubleWritable(rows));
        peer.write(new Text("columns     = "), new DoubleWritable(columns));
        peer.write(new Text("items count = "), new DoubleWritable(
            generatedCount / 3));
        peer.write(new Text("\nValues:"), null);
        for (int i = 0; i < result.length; i++) {
          peer.write(null, new DoubleWritable(result[i]));
        }
      }
    }
{code}

If the purpose is just to print some information as a report, you can use 
"Counter" instead of writing information to a file.

Great job!
                
> [GSoC 2012] Sparse Matrix-Vector multiplication (SpMV) on Hama
> --------------------------------------------------------------
>
>                 Key: HAMA-524
>                 URL: https://issues.apache.org/jira/browse/HAMA-524
>             Project: Hama
>          Issue Type: New Feature
>          Components: bsp core, examples, math
>            Reporter: Edward J. Yoon
>            Assignee: Mikalai Parafeniuk
>              Labels: gsoc, gsoc2012, newbie
>
> Implement Efficient and Fast SpMV algorithm which can be widely used in 
> scientific computing, financial modeling, information retrieval, and others, 
> using Hama Bulk Synchronous Parallel framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to