[
https://issues.apache.org/jira/browse/HAMA-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295466#comment-13295466
]
Thomas Jungblut commented on HAMA-550:
--------------------------------------
Few problems with your patch:
- getSourceVertex can be defined static
- there are a lot of @ annotations in your method documentations that are empty
- There is a TODO. Why?
- There is no need to construct a new Random object everytime, instead create
one with a given seed in the setup method.
- Then you can remove the static method to set the seed, use the configuration
please.
- Testcase seems okay, but when you work with streams please use try catch and
finally.
> Implementation of Bipartite Matching
> ------------------------------------
>
> Key: HAMA-550
> URL: https://issues.apache.org/jira/browse/HAMA-550
> Project: Hama
> Issue Type: New Feature
> Components: examples, graph
> Reporter: Edward J. Yoon
> Assignee: Apurv Verma
> Labels: examples
> Fix For: 0.5.0
>
> Attachments: HAMA-550.patch, HAMA-550.patch, tgraph.txt
>
>
> See http://markmail.org/thread/eaq7p5r2bbjoyfsa
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
