I see the hymmap test failure too on Windows XP, but nothing else apart from a couple of AWT and Swing failures, which were also there in M9.
Shall we leave your patch until after M10 as it's a testcase issue rather than a code issue? 2009/5/27 Oliver Deakin <[email protected]>: > Hi all, > > I've just run the classlib tests on Windows x86 on the latest code in the > federated build and I don't see anything catastrophic there. There's 1 > failure in the portlib tests, in hymmap, which I think is a test case > off-by-one error. I've attached a patch [1] which fixes the test. Apart from > that we look clean. > > Does anyone have any other test reports? Any other platforms? I'm assuming > we're taking r778555 as our testing base for M10. > > Regards, > Oliver > > [1] > Adding 2 to the path size for emptyFile and testFile is incorrect, as > pathLen already counts the rightmost DIR_SEPARATOR. > > Index: modules/portlib/src/test/native/hymmap/shared/hymmap.c > =================================================================== > --- modules/portlib/src/test/native/hymmap/shared/hymmap.c (revision > 779066) > +++ modules/portlib/src/test/native/hymmap/shared/hymmap.c (working copy) > @@ -126,8 +126,8 @@ > execName = strrchr(execPath, DIR_SEPARATOR) + 1; /* Find the rightmost > slash character */ > pathLen = strlen(execPath) - strlen(execName); > > - emptyFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen + > strlen("shared") + 2 + strlen("emptyFile")); /* +2 for the extra slash and > null terminator */ > - testFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen + > strlen("shared") + 2 + strlen("testFile")); > + emptyFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen + > strlen("shared") + 1 + strlen("emptyFile")); /* +1 for the null terminator > */ > + testFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen + > strlen("shared") + 1 + strlen("testFile")); > > strncpy(emptyFile, execPath, pathLen); > strcat(emptyFile, "shared"); > > -- > Oliver Deakin > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 3AU > > -- Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
