5992.v11.patch couldn't be cleanly applied to 0.92
I got:
./src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java.rej
./src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java.rej
./src/main/java/org/apache/hadoop/hbase/master/HMaster.java.rej
./src/main/java/org/apache/hadoop/hbase/master/ServerManager.java.rej
./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java.rej
./src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java.rej
On Thu, Aug 30, 2012 at 2:18 PM, N Keywal <nkey...@gmail.com> wrote:
> Well, if I remember well the test was flaky because of multiple bugs on
> draining servers management... (cf. the mail on test speed :-) )
>
> On Thu, Aug 30, 2012 at 11:07 PM, Ted Yu <yuzhih...@gmail.com> wrote:
>
> > Looking at 5992.v11.patch, it is quite big, touching master,
> > AssignmentManager, etc.
> >
> > At this moment, I want to limit the scope of changes going into 0.92
> > branch.
> >
> > Cheers
> >
> > On Thu, Aug 30, 2012 at 1:55 PM, Dave Wang <d...@cloudera.com> wrote:
> >
> > > Does HBASE-5992 fix this? That fix is only in trunk right now.
> > >
> > > - Dave
> > >
> > > On Thu, Aug 30, 2012 at 1:52 PM, Ted Yu <yuzhih...@gmail.com> wrote:
> > >
> > > > Looking at TestDrainingServer failure:
> > > >
> > > > admin.enableTable(TABLENAME);
> > > > // Assert that every regionserver has some regions on it.
> > > > MiniHBaseCluster cluster = TEST_UTIL.getMiniHBaseCluster();
> > > > for (int i = 0; i < cluster.getRegionServerThreads().size();
> i++) {
> > > > HRegionServer hrs = cluster.getRegionServer(i);
> > > > Assert.assertFalse(hrs.getOnlineRegions().isEmpty());
> > > > }
> > > >
> > > > When table is enabled, it was possible that some region server didn't
> > > carry
> > > > any region.
> > > > It seems the above assertion can be removed.
> > > >
> > > > Cheers
> > > >
> > > > On Wed, Aug 29, 2012 at 11:14 PM, Stack <st...@duboce.net> wrote:
> > > >
> > > > > On Wed, Aug 29, 2012 at 11:03 AM, Ted Yu <yuzhih...@gmail.com>
> > wrote:
> > > > > > According to:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.92/519/testReport/junit/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testSplitBeforeSettingSplittingInZK/
> > > > > >
> > > > > > The test failure was due to:
> > > > > >
> > > > > > java.lang.RuntimeException: java.io.FileNotFoundException:
> > > > > >
> > > > >
> > > >
> > >
> >
> /home/hudson/hudson-slave/workspace/HBase-0.92/trunk/target/classes/hbase-default.xml
> > > > > > (Too many open files)
> > > > > >
> > > > > > I think currently only HBASE-6649 (TestReplication.queueFailover)
> > is
> > > > open
> > > > > >
> > > > > > TestReplication actually hangs in trunk. So it should be fixed
> > across
> > > > > 0.92,
> > > > > > 0.94 and trunk.
> > > > > >
> > > > >
> > > > > I haven't seen 'too many open files' in recent runs.
> > > > >
> > > > > I saw TestDrainingServer fail here
> > > > > https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.92/543/
> > > > > weirdly in setUpBeforeClass
> > > > >
> > > > > TestSplitLogManager here:
> > > > > https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.92/542/
> > > > >
> > > > > It seems like TestMetaReaderEditor failed in 540.....
> > > > >
> > > > > Lets try fix a few of the above such that 0.92 passes more often
> that
> > > > > it fails (Its better already w/ fixes that have gone in lately in
> > that
> > > > > it usually passes when I do a build locally).
> > > > >
> > > > > St.Ack
> > > > >
> > > >
> > >
> >
>
