Agreed, sorry for calling this out on a RC vote. However, I did execute install before site.
On Tue, Jan 30, 2018 at 1:12 PM, Andrew Purtell <[email protected]> wrote: > I think install is mandatory before site. > > > On Jan 30, 2018, at 1:11 PM, Andrew Purtell <[email protected]> > wrote: > > > > You should follow the build instructions on our online manual (look for > the #maven.release anchor). Please file a JIRA and maybe someone suitably > motivated will look at it but I dont see this as a veto-able concern unless > the build fails following our release procedures. That didn't happen. Or > we'd not have a release candidate. :-) > > > > > >> On Jan 30, 2018, at 1:00 PM, Zach York <[email protected]> > wrote: > >> > >> -0 (non-binding) > >> > >> It still looks like mvn clean site fails (Also fails for 1.4.0, hence > not a > >> -1): > >> > >> [ERROR] Failed to execute goal > >> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on > >> project hbase: Error generating maven-javadoc-plugin:2.10.3:aggregate: > >> [ERROR] Exit code: 1 - warning: unknown enum constant When.MAYBE > >> [ERROR] reason: class file for javax.annotation.meta.When not found > >> [ERROR] warning: unknown enum constant When.ALWAYS > >> [ERROR] warning: unknown enum constant When.UNKNOWN > >> [ERROR] javadoc: error - > >> com.sun.tools.doclets.internal.toolkit.util.DocletAbortException: > >> com.sun.tools.javac.code.Symbol$CompletionFailure: class file for > >> javax.annotation.concurrent.Immutable not found > >> > >> There was some initial investigation/discussion in > >> https://issues.apache.org/jira/browse/HBASE-19663 and > >> https://issues.apache.org/jira/browse/HBASE-19780 but that was for > branch-2. > >> Probably not a blocker for the release, but I still wanted to call this > out. > >> > >> Zach > >> > >> > >> > >>> On Tue, Jan 30, 2018 at 4:26 AM, Yu Li <[email protected]> wrote: > >>> > >>> +1 > >>> > >>> Checked sums and signatures: ok > >>> Built from source: ok (7u79) > >>> RAT check: ok (7u79) > >>> Compatibility check: ok (7u79) > >>> Unit tests pass: ok (7u79) > >>> Shell commands: ok (8u101), ran DDL/flush/compact/split commands, > >>> everything looks good > >>> Loaded 1M rows with LTT: ok (8u101), all keys verified, latency and > logs > >>> looks good > >>> > >>> Best Regards, > >>> Yu > >>> > >>>> On 30 January 2018 at 02:28, Andrew Purtell <[email protected]> > wrote: > >>>> > >>>> Thanks Peter, much appreciated. > >>>> > >>>> On Mon, Jan 29, 2018 at 9:35 AM, Peter Somogyi <[email protected] > > > >>>> wrote: > >>>> > >>>>> The tests failed in localhost mode when executed from maven. I've > just > >>>>> checked some integration tests now on 1.4.0 and it fails there as > well, > >>>> so > >>>>> it not a regression. I'm OK with a +1 on this RC. > >>>>> > >>>>> Peter > >>>>> > >>>>> On Mon, Jan 29, 2018 at 5:52 PM, Andrew Purtell < > >>>> [email protected]> > >>>>> wrote: > >>>>> > >>>>>> Are the integration test failures from when it runs in localhost > >>> mode? > >>>> I > >>>>>> think these are long term test issues present since 1.3. Or, is this > >>>> new > >>>>> in > >>>>>> 1.4.1? If these also have the same result with 1.4.0, indicating no > >>> new > >>>>>> regression, would you consider changing your vote? > >>>>>> > >>>>>>> On Jan 29, 2018, at 6:54 AM, Peter Somogyi <[email protected]> > >>>>>> wrote: > >>>>>>> > >>>>>>> 0 > >>>>>>> > >>>>>>> - RAT check: OK > >>>>>>> - Signatures, checksums: OK > >>>>>>> - Build from src: OK > >>>>>>> - Start standalone from src and bin, run shell commands: OK > >>>>>>> - LTT 1M rows: OK > >>>>>>> - Web UI, logs: OK > >>>>>>> - Ran full test suite: passes except integration tests > >>>>>>> > >>>>>>> I had failures in IntegrationTestRpcClient, IntegrationTestMTTR, > >>>>>>> IntegrationTestBigLinkedListWithVisibility and > >>>>>>> IntegrationTestWithCellVisibilityLoadAndVerify. All other tests > >>>> passed > >>>>>> for > >>>>>>> me. > >>>>>>> > >>>>>>>> On Thu, Jan 25, 2018 at 3:45 AM, Andrew Purtell < > >>>> [email protected]> > >>>>>> wrote: > >>>>>>>> > >>>>>>>> The first HBase 1.4.1 release candidate (RC0) is available for > >>>>> download > >>>>>> at > >>>>>>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.1RC0/ and > >>>>> Maven > >>>>>>>> artifacts are available in the temporary repository > >>>>>>>> https://repository.apache.org/content/repositories/ > >>>>> orgapachehbase-1194 > >>>>>> . > >>>>>>>> > >>>>>>>> The git tag corresponding to the candidate is '1.4.1RC0' > >>>> (4b25debc83). > >>>>>>>> > >>>>>>>> A detailed source and binary compatibility report for this release > >>>> is > >>>>>>>> available for your review at > >>>>>>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.1RC0/ > >>>>>>>> compat-check-report.html > >>>>>>>> . > >>>>>>>> > >>>>>>>> A list of the 38 issues resolved in this release can be found at > >>>>>>>> https://s.apache.org/tx1w . > >>>>>>>> > >>>>>>>> Please try out the candidate and vote +1/0/-1. > >>>>>>>> > >>>>>>>> This vote will be open for at least 72 hours. Unless objection I > >>>> will > >>>>>> try > >>>>>>>> to close it Friday February 2, 2018 if we have sufficient votes. > >>>>>>>> > >>>>>>>> Prior to making this announcement I made the following preflight > >>>>> checks: > >>>>>>>> > >>>>>>>> - RAT check passes (7u80) > >>>>>>>> - Unit test suite passes 10 of 10 iterations (8u131) > >>>>>>>> - LTT load 1M rows with 100% verification and 20% updates > >>> (8u131) > >>>>>>>> - PE sequentialWrite, sequentialRead, randomWrite, randomRead, > >>>>>>>> scanRange100 (8u131) > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Best regards, > >>>>>>>> Andrew > >>>>>>>> > >>>>>>>> Words like orphans lost among the crosstalk, meaning torn from > >>>> truth's > >>>>>>>> decrepit hands > >>>>>>>> - A23, Crosstalk > >>>>>>>> > >>>>>> > >>>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Best regards, > >>>> Andrew > >>>> > >>>> Words like orphans lost among the crosstalk, meaning torn from truth's > >>>> decrepit hands > >>>> - A23, Crosstalk > >>>> > >>> >
