Hi everyone, I'm the author of the patch. A separate repo for all the connectors is a great idea! I can make whatever changes necessary to the patch to help.
I have several other integration type projects like this planned. Mike On Tue, Jul 24, 2018, 00:03 Mike Drob <md...@apache.org> wrote: > I would be ok with all of the connectors in a single repo. Doing a repo per > connector seems like a large amount of overhead work. > > On Mon, Jul 23, 2018, 9:12 PM Clay B. <c...@clayb.net> wrote: > > > [Non-binding] > > > > I am all for the Kafka Connect(er) as indeed it makes HBase "more > > relevant" and generates buzz to help me sell HBase adoption in my > > endeavors. > > > > Also, I would like to see a connectors repo a lot as I would expect it > can > > make the HBase source and releases more obvious in what is changing. Not > > to distract from Kafka, but Spark has in the past been a hang-up and > seems > > a good fit in such a repo too; as such, I would prefer Apache over > GitHub. > > > > -Clay > > > > On Mon, 23 Jul 2018, Andrew Purtell wrote: > > > > >> Would we make a new repo called hbase-connectors and move REST, > thrift, > > > and this new patch there? > > > > > > I like this idea. We are already releasing hbase-thirdparty like this. > > > > > > > > > On Mon, Jul 23, 2018 at 5:47 PM Stack <st...@duboce.net> wrote: > > > > > >> (Thanks for the good discussion) > > >> > > >> Where we think 'outside of HBase' would be? > > >> > > >> Github seems too 'remote' from project and from Apache? Would we make > a > > new > > >> repo called hbase-connectors and move REST, thrift, and this new patch > > >> there? > > >> > > >> Thanks, > > >> S > > >> > > >> On Mon, Jul 23, 2018 at 3:50 PM Josh Elser <els...@apache.org> wrote: > > >> > > >>> I'm -0 for including this into the main hbase tree. I feel like we've > > >>> made a bit of progress in cleaning up our core, and this strikes me > as > > a > > >>> step in the wrong direction. > > >>> > > >>> At the same time, the integration seems nice enough (for the same > > >>> reasons Andrew points out). Is there a reason this couldn't exist > > >>> outside of HBase (at the ASF or otherwise)? Given a quick glance at > the > > >>> patch, it would be quite trivial to keep separate (just requires some > > >>> heavier scripting to get it off the ground that the HBase scripts do > > >>> setup for). I feel like that will decrease our debt while we see if > > >>> people start using it. Our API should be more than stable enough to > > >>> prevent any worry about drift happening from core to this project. > > >>> > > >>> On 7/23/18 6:35 PM, Stack wrote: > > >>>> We have a very nice contrib sitting up in HBASE-15320 which via a > > proxy > > >>> -- > > >>>> so minimal dependencies -- adds source and sink for Kafka Connect. > It > > >> is > > >>>> nicely contained inside two new hbase-kafka-* modules. > > >>>> > > >>>> We good w/ taking on this new feature? > > >>>> > > >>>> It looks good to me. Check it out up on HBASE-15320. I was going to > > >>> commit > > >>>> to tip of branch-2 so it'd show up in hbase-2.2.x unless you all > want > > >>> some > > >>>> backporting action going on. > > >>>> > > >>>> S > > >>>> > > >>> > > >> > > > > > > > > > -- > > > Best regards, > > > Andrew > > > > > > Words like orphans lost among the crosstalk, meaning torn from truth's > > > decrepit hands > > > - A23, Crosstalk > > > > > > >