+1 (non-binding)

-- Build from src - Ok
-- Able to deploy and run 2.0.3 on existing 2.0 deployment without any
issues
-- Basic shell commands - Ok
-- UI - Ok
-- Started local cluster, ran some selected Integration test - ok
-- Ran rat check on source - Success
-- SHA and Signatures - Good
-- UT - OK (TestFifoRpcScheduler and TestMasterFailoverWithProcedures passes
for me)

Regards,
Ankit Singhal

On Thu, Nov 29, 2018 at 12:33 PM Stack <[email protected]> wrote:

> Thank you Azhaku.
> S
>
> On Thu, Nov 29, 2018 at 11:10 AM Azhaku Sakthi Vel Muthu Krishnan
> <[email protected]> wrote:
>
> > (+1 Non Binding)
> >
> >    1. Checksums and signatures(both src and bin): OK
> >    2. Rat Check: OK
> >    3. Built from source: OK
> >    4. Basic Shell commands: OK
> >    5. Web UI: OK
> >    6. LTT with 1M rows: OK
> >    7. Unit Tests run failed mid way, need to re-trigger. But encountered
> >    TestFifoRpcScheduler failure so far:
> >       - [ERROR]
> >       testCallQueueInfo(org.apache.hadoop.hbase.ipc.TestFifoRpcScheduler)
> > Time
> >       elapsed: 7.404 s <<< FAILURE!
> >       - java.lang.AssertionError: expected:<10> but was:<9>
> >       -         at
> >
> >
> org.apache.hadoop.hbase.ipc.TestFifoRpcScheduler.testCallQueueInfo(TestFifoRpcScheduler.java:137)
> >
> > Sakthi
> >
> > On Thu, Nov 29, 2018 at 8:08 AM Sean Busbey <[email protected]> wrote:
> >
> > > On Thu, Nov 29, 2018 at 10:06 AM Allan Yang <[email protected]>
> wrote:
> > > >
> > > > I think we can release 2.0.3 first then fix these flaky tests later.
> I
> > > > glanced at the flaky board for branch-2.1, those tests are still
> flaky
> > in
> > > > branch-2.1[1], they are not the fault of 2.0.3. They should not block
> > the
> > > > release of 2.0.3.
> > > >
> > >
> > > I agree with Allan here. I should be able to finish running through
> > > testing the RC this evening.
> > >
> >
>

Reply via email to