It is the Dragon Boat Festival in China so probably Guanghao will not reply here until 6.10. Let's extend the vote for several days. And he filed HBASE-22542 which is a blocker for 2.2.0 but I do not think it is. Need to talk to him when he is back...
Stack <st...@duboce.net> 于2019年6月6日周四 下午1:39写道： > +1 > > Looks basically wholesome except for unit tests. More on this below. > > I ran ./dev-support/hbase-vote.sh --source > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC5/ --output-dir > /tmp/check_release > > * Signature: ok > * Checksum : ok > * Rat check (1.8.0_102): ok > - mvn clean apache-rat:check > * Built from source (1.8.0_102): ok > - mvn clean install -DskipTests > * Unit tests pass (1.8.0_102): failed > - mvn test -P runAllTests > > I started up the built hbase. Loaded data, verified it there. Did a few > times... loading up 10M rows at a time. > > Poked around in fs and on ui. Looks good. > > Looking on disk, RELEASENOTES.md only has 2.2.0 Release Notes. All others > are dropped. Ditto for CHANGES.md. Intentional? > > nit: The links in the email above are a bit odd... refer to RC4? > > On unit tests: > > I'd been running unit tests earlier. In particular I find that these two > items fail locally for me repeatedly on branch-2.2 > > * TestLockManager > * TestSplitTransactionOnCluster > > Looking up on nightlies, it is pretty red but a recent pass...: > https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/. The last > few > failures look like plain flakies. I ran all the tests that show in flakey > list locally and they passed: > > https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html > ... even the two that fail for me locally. Looking at the history on the > those that fail for me locally, they seem like legit failures. Let me try > and dig in. Hopefully as branch-2.2 progresses, we can turn the nightly > mostly blue. > > > Thanks for putting up the RC Guanghao Zhang, > S > > > On Tue, Jun 4, 2019 at 4:11 AM Guanghao Zhang <zghao...@gmail.com> wrote: > > > Please vote on this release candidate (RC) for Apache HBase 2.2.0. > > This is the first release of the branch-2.2 line. > > > > The VOTE will remain open for at least 72 hours. > > > > [] +1 > > [] +0/-0 > > [] -1 Do not release this package because ... > > > > The tag to be voted on is 2.2.0-RC5. The release files, including > > signatures, digests, etc. can be found at: > > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC5/ > > > > Maven artifacts are available in a staging repository at: > > https://repository.apache.org/content/repositories/orgapachehbase-1316/ > > > > Signatures used for HBase RCs can be found in this file: > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > The list of bug fixes going into 2.2.0 can be found in included > > CHANGES.md and RELEASENOTES.md available here: > > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC5/CHANGES.md > > <https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC4/CHANGES.md> > > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC5/RELEASENOTES.md > > <https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC4/RELEASENOTES.md> > > > > A detailed source and binary compatibility report for this release is > > available at > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC5/api_compare_2.2.0RC5_to_2.1.4.html > > < > > > https://dist.apache.org/repos/dist/dev/hbase/2.2.0RC4/api_compare_2.2.0RC4_to_2.1.4.html > > > > > > > To learn more about Apache HBase, please see http://hbase.apache.org/ > > > > Thanks, > > Guanghao Zhang > > >
