The TestCanaryTool is a mess, the output is flooded with "Failed to renew lease" but I could get a successful run, finally.
This is my jdk version openjdk version "1.8.0_222" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode) Andrew Purtell <andrew.purt...@gmail.com> 于2020年4月3日周五 上午11:40写道： > Thanks. Since you can’t reproduce I’ll change my vote to -0. > > Weird you don’t see the TestCanaryTool failure. Perhaps that is because of > differing JDK versions. > > > On Apr 2, 2020, at 8:27 PM, 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > > > > I can not reproduce these failure locally. > > > > And for testScanAfterDeletingSpecifiedRowV2, maybe the problem is the > > timestamp. If your computer is fast enough, the later several puts may > have > > the same timestamp with the delete at the beginning, so the later put > will > > be masked by the previous delete, which lead to the failure. You could > try > > to set the same timestamp for all the delete and put, then you will get a > > failure like this > > > > java.lang.AssertionError: expected:<3> but was:<0> > > at org.junit.Assert.fail(Assert.java:88) > > at org.junit.Assert.failNotEquals(Assert.java:834) > > at org.junit.Assert.assertEquals(Assert.java:645) > > at org.junit.Assert.assertEquals(Assert.java:631) > > at > > > org.apache.hadoop.hbase.client.TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2(TestFromClientSide3.java:253) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > > at > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > at java.lang.reflect.Method.invoke(Method.java:498) > > at > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > > at > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > > at > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > > at > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > > at > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > > at > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > > at > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > > at > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > > at > > > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > > at > > > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > > at java.lang.Thread.run(Thread.java:748) > > > > So I do not think this is a blocker one, just a test issue. > > > > Thanks. > > > > Andrew Purtell <apurt...@apache.org> 于2020年4月3日周五 上午9:53写道： > > > >> -1 (binding) > >> > >> * Signature: ok > >> * Checksum : ok > >> * Rat check (1.8.0_232): ok > >> - mvn clean apache-rat:check > >> * Built from source (1.8.0_232): ok > >> - mvn clean install -DskipTests > >> * Unit tests pass (1.8.0_232): failed > >> - mvn package -P runAllTests > >> > >> TestHRegionWithInMemoryFlush.testCheckAndMutate_WithCorrectValue 100% > >> failure > >> > >> > >> > org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush.testCheckAndMutate_WithCorrectValue > >> Run 1: > >> > >> > TestHRegionWithInMemoryFlush>TestHRegion.testCheckAndMutate_WithCorrectValue:1986 > >> expected:<true> but was:<false> > >> Run 2: > >> > >> > TestHRegionWithInMemoryFlush>TestHRegion.testCheckAndMutate_WithCorrectValue:1986 > >> expected:<true> but was:<false> > >> Run 3: > >> > >> > TestHRegionWithInMemoryFlush>TestHRegion.testCheckAndMutate_WithCorrectValue:1986 > >> expected:<true> but was:<false> > >> Run 4: > >> > >> > TestHRegionWithInMemoryFlush>TestHRegion.testCheckAndMutate_WithCorrectValue:1986 > >> expected:<true> but was:<false> > >> > >> TestCanaryTool is broken, lots of these: > >> > >> [ERROR] Run 2: TestCanaryTool.testReadTableTimeouts:218 > >> Argument(s) are different! Wanted: > >> mockAppender.doAppend( > >> <custom argument matcher> > >> ); > >> -> at > >> > >> > org.apache.hadoop.hbase.tool.TestCanaryTool.testReadTableTimeouts(TestCanaryTool.java:218) > >> Actual invocations have different arguments: > >> mockAppender.doAppend( > >> org.apache.log4j.spi.LoggingEvent@5c21284d > >> ); > >> Some flakes. The TestFromClientSide3 results are concerning because they > >> could be a correctness issue: > >> > >> org.apache.hadoop.hbase.regionserver.TestRegionReplicas.null > >> Run 1: > >> TestRegionReplicas.testVerifySecondaryAbilityToReadWithOnFiles:476 » > >> TestTimedOut > >> Run 2: PASS > >> > >> > >> > org.apache.hadoop.hbase.client.TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2 > >> Run 1: TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:253 > >> expected:<3> but was:<2> > >> Run 2: TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:253 > >> expected:<3> but was:<2> > >> Run 3: PASS > >> > >> org.apache.hadoop.hbase.master.assignment.TestRegionMoveAndAbandon.test > >> Run 1: TestRegionMoveAndAbandon.test:118 » Runtime > >> org.apache.hadoop.hbase.client.Ret... > >> Run 2: PASS > >> > >> > >> > org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures.testDisableTableWithFailover > >> Run 1: TestMasterFailoverWithProcedures.setup:76 » IO Shutting down > >> Run 2: PASS > >> > >> > >> > org.apache.hadoop.hbase.replication.regionserver.TestReplicator.testReplicatorWithErrors > >> Run 1: TestReplicator.testReplicatorWithErrors:158 We did not > replicate > >> enough rows expected:<10> but was:<6> > >> Run 2: PASS > >> > >> > >> > org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe.testScanAfterDeletingSpecifiedRowV2 > >> Run 1: > >> > >> > TestFromClientSide3WoUnsafe>TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:253 > >> expected:<3> but was:<2> > >> Run 2: > >> > >> > TestFromClientSide3WoUnsafe>TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:253 > >> expected:<3> but was:<2> > >> Run 3: PASS > >> > >> > >>> On Tue, Mar 31, 2020 at 9:15 PM Duo Zhang <zhang...@apache.org> wrote: > >>> > >>> Please vote on this Apache hbase release candidate, > >>> hbase-2.1.10RC1 > >>> > >>> The VOTE will remain open for at least 72 hours. > >>> > >>> [ ] +1 Release this package as Apache hbase 2.1.10 > >>> [ ] -1 Do not release this package because ... > >>> > >>> The tag to be voted on is 2.1.10RC1: > >>> > >>> https://github.com/apache/hbase/tree/2.1.10RC1 > >>> > >>> The release files, including signatures, digests, as well as CHANGES.md > >>> and RELEASENOTES.md included in this RC can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/hbase/2.1.10RC1/ > >>> > >>> Maven artifacts are available in a staging repository at: > >>> > >>> > https://repository.apache.org/content/repositories/orgapachehbase-1387/ > >>> > >>> Artifacts were signed with the 9AD2AE49 key which can be found in: > >>> > >>> https://dist.apache.org/repos/dist/release/hbase/KEYS > >>> > >>> 2.1.10 includes ~23 bug and improvement fixes done since the 2.1.9. > >>> > >>> To learn more about apache hbase, please see > >>> http://hbase.apache.org/ > >>> > >>> Thanks, > >>> Your HBase Release Manager > >>> > >> > >> > >> -- > >> Best regards, > >> Andrew > >> > >> Words like orphans lost among the crosstalk, meaning torn from truth's > >> decrepit hands > >> - A23, Crosstalk > >> >
