I was just about to reply with the same -- Josh is faster :) +1 on considering the full surface area of the APIs being exposed.
I also wonder if exposing the metrics infrastructure is something of interest more broadly than Phoenix. Seems like any coprocessor might want to provide or monitor some metric value. On Thu, Jun 11, 2020 at 9:08 AM Josh Elser <els...@apache.org> wrote: > My only concern is that you can't just mark these two classes a > LimitedPrivate for Phoenix -- you would also have to mark > MutableRangeHistogram, MutableHistogram (and the rest of the class > hierarchy) to make sure that we don't make it super confusing as to what > comes from LimitedPrivate classes and what is coming from Private classes. > > Would it be better to just say: make > ./hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib > LimitedPrivate? > > Do you also need the stuff in > hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase to push > metrics back through the HBase metrics subsystem? > > Sorry for the late reply. Just want to make sure we open up the > audience, we open it sufficiently. > > On 6/8/20 1:15 PM, Rushabh Shah wrote: > > Hi, > > Currently the IA for MutableSizeHistogram and MutableTimeHistogram is > > private. We want to use these classes in PHOENIX project and I thought we > > can leverage the existing implementation from hbase histo implementation. > > IIUC the private IA can't be used in other projects. Proposing to make it > > LimitedPrivate and mark HBaseInterfaceAudience.PHOENIX. Please suggest. > > Related jira: https://issues.apache.org/jira/browse/HBASE-24520 > > >
