OK. Good. Thanks Guanghao. So finally we get 3 +1s...
The vote passes. Guanghao Zhang <zghao...@gmail.com> 于2021年10月26日周二 上午9:33写道: > Change my vote to +1. > > Thanks. > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年10月25日周一 下午11:19写道: > > > OK, I got an error when upgrading to jdk8u312. > > > > TestLogLevel.testLogLevelByHttp:402 Expected to find 'Unrecognized SSL > > message' but got unexpected exception:javax.net.ssl.SSLException: > > Unsupported or unrecognized SSL message > > > > The actual testing code is > > > > try { > > testDynamicLogLevel(LogLevel.PROTOCOL_HTTP, > LogLevel.PROTOCOL_HTTPS, > > false); > > fail("A HTTPS Client should not have succeeded in connecting to a > > HTTP server"); > > } catch (SSLException e) { > > GenericTestUtils.assertExceptionContains("Unrecognized SSL > message", > > e); > > } > > } > > > > So I think this is just a test issue, during upgrading the JDK has > changed > > the error message from 'Unrecognized SSL message' to 'Unsupported or > > unrecognized SSL message'. It does not indicate any real problems in our > > non testing code. > > > > So I do not think this should be a blocker. > > > > WDYT Guanghao? > > > > Thanks. > > > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年10月25日周一 下午11:04写道: > > > > > It passed for me with 8u252. > > > > > > What is the failure message? > > > > > > Guanghao Zhang <zghao...@gmail.com> 于2021年10月25日周一 下午6:48写道: > > > > > >> +0 from me as there was one UT failed. Will change the vote if it is > > not a > > >> blocker. > > >> *Signature: ok > > >> *Checksum : ok > > >> *Rat check (1.8.0_301): ok > > >> - mvn clean apache-rat:check > > >> *Built from source (1.8.0_301): ok > > >> - mvn clean install -DskipTests > > >> *Unit tests (1.8.0_301): TestLogLevel always failed > > >> - mvn package -P runSmallTests > > >> *Started a mini cluster, UI check: ok > > >> *Shell check: ok > > >> > > >> Reid Chan <reidchan0...@gmail.com> 于2021年10月21日周四 下午12:01写道: > > >> > > >> > +1 > > >> > * Signature: ok > > >> > * Checksum : ok > > >> > * Rat check (1.8.0_232): ok > > >> > - mvn clean apache-rat:check > > >> > * Built from source (1.8.0_232): ok > > >> > - mvn clean install -DskipTests > > >> > * Unit tests pass (1.8.0_232): ok > > >> > - mvn package -P runSmallTests > > >> > -Dsurefire.rerunFailingTestsCount=3 > > >> > > > >> > > > >> > On Thu, Oct 21, 2021 at 9:27 AM Duo Zhang <zhang...@apache.org> > > wrote: > > >> > > > >> > > Please vote on this Apache HBase release candidate, > > >> > > hbase-1.4.14RC0 > > >> > > > > >> > > The VOTE will remain open for at least 72 hours. > > >> > > > > >> > > [ ] +1 Release this package as Apache HBase 1.4.14 > > >> > > [ ] -1 Do not release this package because ... > > >> > > > > >> > > The tag to be voted on is 1.4.14RC0: > > >> > > > > >> > > https://github.com/apache/hbase/tree/1.4.14RC0 > > >> > > > > >> > > This tag currently points to git reference > > >> > > > > >> > > e7cbc2debc11a01dd4f3e6f6d6992b7bd307bbcb > > >> > > > > >> > > The release files, including signatures, digests included > > >> > > in this RC can be found at: > > >> > > > > >> > > https://dist.apache.org/repos/dist/dev/hbase/1.4.14RC0/ > > >> > > > > >> > > The release notes can be found at: > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310753&version=12346995 > > >> > > > > >> > > Maven artifacts are available in a staging repository at: > > >> > > > > >> > > > > >> > > > https://repository.apache.org/content/repositories/orgapachehbase-1467/ > > >> > > > > >> > > Artifacts were signed with the 9AD2AE49 key which can be found in: > > >> > > > > >> > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > >> > > > > >> > > Notice that 1.4.14 will be the last release for the 1.4.x release > > >> line. > > >> > > Users > > >> > > are encouraged to upgrade to the 2.x stable release line. > > >> > > > > >> > > To learn more about Apache HBase, please see > > >> > > > > >> > > http://hbase.apache.org/ > > >> > > > > >> > > Thanks, > > >> > > Your HBase Release Manager > > >> > > > > >> > > > >> > > > > > >