Makes sense and if nobody has a concern we can do that. Also you wanted to support the change to the RSGroup API and put back the unit test (and fix it to not flake), correct, which seems fine to me too.
On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) <[email protected]> wrote: > The ReplicationLoadSink change is done in HBASE-26490, this is the commit > > > https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 > > The constructor is marked as IA.Private so I do not think we need to > restore it back. > > Thanks. > > Andrew Purtell <[email protected]> 于2022年6月1日周三 13:08写道： > > > This is not a VOTE. > > > > HBase 2.5.0RC0 is ready for testing, other evaluation, and consideration > of > > compatibility concerns. > > > > The release notes need to be rebased on the latest 2.4.x release, 2.4.12. > > Fix > > versions on relvant JIRAs must be cleaned up first. This is in progress. > I > > also plan to try our new audit tool for matching git history and fix > > versions. > > > > There are known flaky unit tests and minor issues. You can find them by > > searching for the '2.5.1' fix version, or this URL: > > > > https://s.apache.org/hbase-v2.5.1 > > > > The compatibility report, based on 2.4.12, can be found here: > > > > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_compare_2.4.12_to_2.5.0RC0.html > > > > An initial response to some of the findings can be found on HBASE-27081, > > along > > with additional discussion. Further discussion is probably necessary. > > > > The tag to be evaluated is 2.5.0RC0: > > > > https://github.com/apache/hbase/tree/2.5.0RC0 > > > > This tag currently points to git reference 2da2dd917 . > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > > > https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/ > > > > Maven artifacts are available in a staging repository at: > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1486/ > > > > Artifacts were signed with the 0xD5365CCD key which can be found in: > > > > https://downloads.apache.org/hbase/KEYS > > > > The second release candidate, 2.5.0RC1, will be made available for > > evaluation > > after discussion and any necessary changes and fixes have settled. > > > > Best, > > > > Your 2.5 Release Manager > > > -- Best regards, Andrew Unrest, ignorance distilled, nihilistic imbeciles - It's what we’ve earned Welcome, apocalypse, what’s taken you so long? Bring us the fitting end that we’ve been counting on - A23, Welcome, Apocalypse
