On Thu, 2008-01-10 at 17:17 +0100, Johannes Koch wrote:
> Oleg Kalnichevski schrieb:
> > And what about the test case?
>
> Does it make sense to remove the query
>
> "?invk=" + (++this.invocations)
>
> from the URIs in
> TestRedirects.CircularRedirectService.handle(
> final HttpRequest request,
> final HttpResponse response,
> final HttpContext context)
>
> ?
It appears so. I checked both patches in. Many thanks, Johannes
Oleg
> plain text document attachment (Patch_TestRedirects_20080110.txt)
> Index:
> D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
> ===================================================================
> ---
> D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
> (revision 610764)
> +++
> D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
> (working copy)
> @@ -145,10 +145,10 @@
> String uri = request.getRequestLine().getUri();
> if (uri.startsWith("/circular-oldlocation")) {
> response.setStatusLine(ver, HttpStatus.SC_MOVED_TEMPORARILY);
> - response.addHeader(new BasicHeader("Location",
> "/circular-location2?invk=" + (++this.invocations)));
> + response.addHeader(new BasicHeader("Location",
> "/circular-location2"));
> } else if (uri.startsWith("/circular-location2")) {
> response.setStatusLine(ver, HttpStatus.SC_MOVED_TEMPORARILY);
> - response.addHeader(new BasicHeader("Location",
> "/circular-oldlocation?invk=" + (++this.invocations)));
> + response.addHeader(new BasicHeader("Location",
> "/circular-oldlocation"));
> } else {
> response.setStatusLine(ver, HttpStatus.SC_NOT_FOUND);
> }
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
