On 03/02/2008, Roland Weber <[EMAIL PROTECTED]> wrote: > sebb wrote: > > It looks OK to me - the method is aligned with the @ - but I have tabs > > set at 4 spaces. > > > > I can fix those shortly. > > Thanks. It's been a while since I had to deal with > tab vs. space problems, sorry for not spotting that > in the first place.
No problem; they've all been fixed now. While I was scanning the code for the problems I'd introduced, I noticed that there are quite a few tabs in the http-core code (which is not 1.5, so I did not add @Override). Some of these are really odd, e.g. tabs in the middle of groups of spaces. There are often a few lines together with embedded tabs, usually the rest of the source uses spaces for indenting. Is it worth me fixing these? I'm happy to do so. Maybe there should be a "no tabs" policy? Might be useful to have a section in the http://hc.apache.org/dev-docs.html page about coding conventions. Or maybe on the Wiki. > cheers, > Roland > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
