[
https://issues.apache.org/jira/browse/HTTPCLIENT-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565195#action_12565195
]
Sebb commented on HTTPCLIENT-740:
---------------------------------
Seems OK to me as far as multi-threadedness is concerned.
Probably ought to start documenting fields such as numConnections with the
@GuardedBy annotation.
This is not a standard annotation, so the build would need to be updated to
depend on the jar.
> AbstractConnPool constructor calls thread.Start()
> -------------------------------------------------
>
> Key: HTTPCLIENT-740
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-740
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
> Assignee: Roland Weber
> Priority: Trivial
> Fix For: 4.0 Alpha 3
>
>
> AbstractConnPool constructor calls thread.Start()
> Findbugs says:
> Constructor invokes Thread.start()
> The constructor starts a thread. This is likely to be wrong if the class is
> ever extended/subclassed, since the thread will be started before the
> subclass constructor is started.
> The class is not final (and the constructor is protected) which suggests that
> the class is intended to be extended...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
