[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Berlin updated HTTPCLIENT-734:
----------------------------------

    Attachment: changes.txt

This patch takes a different approach than the prior one.  Instead of requiring 
the user of the ClientConnectionManager to assume that it blocks, an 
AbortableHttpRequest is now passed into getConnection.  The 
ClientConnectionManager must set a ConnectionReleaseTrigger on the request to 
support aborting it.

The patch is a little more intrusive than the prior one (in that it touches 
more classes and changes some method signatures), but it could be worth it.

There's some more tests in TestTSCCMNoServer to make sure that 
ThreadSafeClientConnectionManager is doing the right thing.

(Included in this patch is the small changes & tests for HTTPCLIENT-759, 
because it's hard to separate the environments.)

> request.abort() should interrupt thread waiting for a connection
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-734
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-734
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Roland Weber
>             Fix For: 4.0 Beta 1
>
>         Attachments: changes.txt, changes.txt, connabort.patch
>
>
> Calls to HttpRequestBase.abort() will not unblock a thread that is still 
> waiting for a connection and therefore has no ConnectionReleaseTrigger yet.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to