[
https://issues.apache.org/jira/browse/HTTPCORE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613258#action_12613258
]
Oleg Kalnichevski commented on HTTPCORE-165:
--------------------------------------------
Patrick,
IOReactorEH defines a very simple contract: it can declare certain classes of
exceptions as handled, which would otherwise be considered fatal. That is it.
If a caller does not act on this information this is not a problem of the
IOReactorEH interface.
Anyway, you are very welcome to demonstrate a better way of doing it by
submitting a patch.
Oleg
> Poor handling of CancelledKeyException with custom IOReactorExceptionHandler
> -----------------------------------------------------------------------------
>
> Key: HTTPCORE-165
> URL: https://issues.apache.org/jira/browse/HTTPCORE-165
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-beta2
> Reporter: Patrick Moore
> Fix For: 4.0-beta3
>
> Attachments: cancelledkey.patch
>
>
> IOReactorExceptionHandler documentation for handle(RuntimeException ex) is
> misleading. Specifically the documentation says :
> @return <code>true</code> if it is safe to ignore the exception
> and continue execution of the I/O reactor; <code>false</code> if the
> I/O reactor must throw [EMAIL PROTECTED] RuntimeException} and terminate
> However, a CancelledKeyException should be rethrown because the BaseIOReactor
> and the AbstractIOReactor expect and handle CancelledKeyException correctly.
> BUT -- NOT always.
> Looking at the call stack for where
> IOReactorExceptionHandler.handle(RuntimeException) is called reveals some
> problems.
> If a custom IOReactorExceptionHandler was to return false (indicating that
> the CanceledKeyException was to be rethrown or to do the rethrow itself)
> WOULD result in the IOReactor being shutdown:
> BaseIOReactor.sessionClosed(IOSession)
> BaseIOReactor.timeoutCheck(SelectionKey, long)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
