On 30/11/2008, Oleg Kalnichevski <[EMAIL PROTECTED]> wrote: > On Mon, 2008-12-01 at 12:29 +0000, sebb wrote: > > I just added some Javadoc for EntityUtils, and noticed that: > > > > org.apache.http.util.EntityUtils.getContentCharSet(HttpEntity entity) > > > > says it throws ParseException - however, that does not appear to be > possible. > > > > Should the throws clause be removed from it and its callers? > > > > > Hi Sebastian, > > ParseException can occur while tokenizing header value into separate > header elements in the Header#getElements() method. I think the method > declaration is correct.
Oops - yes, I missed that ... > However, it just occurred to me that it should have been rethrown as as > a checked protocol exception in the Header#getElements() method. ... mainly because it is an unchecked Exception. > Damn. I've updated the EntityUtils Javadoc. > Oleg > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
