[
https://issues.apache.org/jira/browse/HTTPCLIENT-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853073#action_12853073
]
Ryan Stewart commented on HTTPCLIENT-930:
-----------------------------------------
Yeah, I can't disagree with any of that. For my application, at least, I'll
have to try the "escape if it looks unescaped" thing. If you don't want to add
support for that in HttpClient, can I get a new method in
DefaultRedirectHandler that I can override and add this behavior to? Either:
protected String getLocation(HttpResponse response) { ... }
or
protected URI createLocationUri(String location) { ... }
Extract one (or both) of these methods from the getLocationURI method, and then
I could encode the string either after it gets extracted from the response or
before the URI is built.
> Unencoded redirect URI causes exception when following redirects
> ----------------------------------------------------------------
>
> Key: HTTPCLIENT-930
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-930
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0.1
> Reporter: Ryan Stewart
>
> When HttpClient is set to follow redirects, the DefaultRedirectHandler gets
> the redirect location from the appropriate request header and attempts to
> create a new java.net.URI from it. If the location contains an invalid URI
> character, creating the URI fails. For example, if the redirect location were
> "/foo?bar=<baz/>", it would fail because the '<' and '>' are not legal in a
> URI.
> I'm not sure if this should actually be considered a bug in HttpClient, since
> the website in question should probably be responsible for encoding the URI
> appropriately; however, browsers handle the situation gracefully, and it
> would be nice if this excellent library would do so as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
