[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stepan Koltsov updated HTTPCLIENT-942:
--------------------------------------

    Description: 
http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.0.1/httpclient/src/examples/org/apache/http/examples/client/ClientConnectionRelease.java

is incorrect: 

1. if error happens in BufferedReader constructor (OutOfMemoryError, 
StackOverflowError), reader.close() is not called and connection is not released

2. if error happens in reader.readLine(), reader.close() is called, but 
httpget.abort() is not.

  was:
http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.0.1/httpclient/src/examples/org/apache/http/examples/client/ClientConnectionRelease.java

is incorrect: if error happens in BufferedReader constructor or in 
reader.readLine()  (OutOfMemoryError, StackOverflowError), reader.close() is 
not called and connection is not released


> ClientConnectionRelease example is incorrect
> --------------------------------------------
>
>                 Key: HTTPCLIENT-942
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-942
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Stepan Koltsov
>
> http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.0.1/httpclient/src/examples/org/apache/http/examples/client/ClientConnectionRelease.java
> is incorrect: 
> 1. if error happens in BufferedReader constructor (OutOfMemoryError, 
> StackOverflowError), reader.close() is not called and connection is not 
> released
> 2. if error happens in reader.readLine(), reader.close() is called, but 
> httpget.abort() is not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to